Implement --log CLI argument with rx and tx options#84
Implement --log CLI argument with rx and tx options#84slook wants to merge 2 commits intosoulfind-dev:masterfrom
Conversation
73b64da to
64a8fa8
Compare
|
Alright, maybe this could be an option. Just remember that we're sacrificing extensibility, so don't expect me to consider any future requests regarding advanced filtering or categories. Do we need combined categories like |
This is already quite a flexible arrangement, any more advanced filtering than what's done here would require the parameters to be in a very specific order which would make the command line interface too difficult to understand. The only other useful filtering that could be added as options of the
If desired at a later time, those features could be added into the
Are you suggesting that it would be less confusing if the presence of an |
Enables additional logging, and takes an optional list of log categories to enable, with filtering by message code number. Co-authored-by: Mat <mail@mathias.is>
Adds proper support for shell quoted values (like "file name.db") with strict rejection of misplaced or unexpected inputs.
|
I pushed a change to the cli module to callback an array of This constrains an option to take only its correct amount of values (i.e. zero or one, except for options with
... and this eliminates the need for any custom splitting to select |
Enables additional logging, and takes an optional list of log categories to enable, with filtering by message code number.
--logcategories:conn: Connectionsdb: Database operationsmsg: Includes bothrandtr: Received network messagesrx: Received network messages with hexadecimal bytest: Transmitted network messagestx: Transmitted network messages with hexadecimal bytesx: Includes bothrxandtx1..1003: Filter by message codeBased on PR #81 by @jpdillingham and PR #82 by @mathiascode